Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Post v2.5.0 release: Update coastal/ in uw-coupled-drivers repo #11

Open
maddenp-noaa opened this issue Nov 4, 2024 · 0 comments
Open

Post v2.5.0 release: Update coastal/ in uw-coupled-drivers repo #11

maddenp-noaa opened this issue Nov 4, 2024 · 0 comments
Assignees
@maddenp-noaa

Comments

@maddenp-noaa
Copy link

In coastal.py in uw-coupled-drivers:

  • from uwtools.api.file import link -> from uwtools.api.fs import link (module name change)
  • controller=self.driver_name -> controller=[self.driver_name()] (controller now takes a list[str] keypath, and self.driver_name() is now callable)
  • Remove @property decorator from method driver_name().
  • Test changes -- coordinate with Coastal team to be sure changes work correctly.

See open PR: ufs-community/uw-coupled-drivers#2
@maddenp-noaa maddenp-noaa self-assigned this Nov 4, 2024
@maddenp-noaa maddenp-noaa converted this from a draft issue Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maddenp-noaa maddenp-noaa

Labels
None yet
Projects
Unified Workflow Kanban
Status: Blocked
Milestone
No milestone
Development

No branches or pull requests
1 participant
@maddenp-noaa