Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reject an incoming call with a custom comment #491

Open
iveto89 opened this issue Jul 12, 2018 · 3 comments
Open

Reject an incoming call with a custom comment #491

iveto89 opened this issue Jul 12, 2018 · 3 comments
Labels
code-generation issue deals with generated code difficulty: medium fix is medium in difficulty status: help wanted requesting help from the community type: community enhancement feature request not on Twilio's roadmap

Comments

@iveto89
Copy link

iveto89 commented Jul 12, 2018

It would be useful to add a custom comment when we reject an incoming call. Currently, only rejected, busy are allowed for reason. This comment will translate into xml comment.

Code Snippet

$response = new TwiML();
$response->reject(['reason' => 'busy'])->comment('Unknown number');
@childish-sambino
Copy link
Contributor

Similar to twilio/twilio-node#503

DOMDocument supports this: https://www.php.net/manual/en/domdocument.createcomment.php

Adding it to our internal backlog to be prioritized. Pull requests and +1s on the issue summary will help it move up the backlog.

@childish-sambino childish-sambino added code-generation issue deals with generated code difficulty: medium fix is medium in difficulty status: help wanted requesting help from the community type: community enhancement feature request not on Twilio's roadmap labels Nov 27, 2019
@prionkor
Copy link

prionkor commented Jan 5, 2020

Adding comments on reject and other twiml will be very helpful for users and also for debugging purpose. NodeJS version of the SDK may also support this.

@Mapteg34
Copy link

+1 for me, and this function implemented in node: twilio/twilio-node#503

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code-generation issue deals with generated code difficulty: medium fix is medium in difficulty status: help wanted requesting help from the community type: community enhancement feature request not on Twilio's roadmap
Projects
None yet
Development

No branches or pull requests

4 participants