Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to allow ports as variables in docker compose #46

Open
tushar5526 opened this issue May 22, 2024 · 7 comments · May be fixed by #53
Open

Add support to allow ports as variables in docker compose #46

tushar5526 opened this issue May 22, 2024 · 7 comments · May be fixed by #53

Comments

@tushar5526
Copy link
Owner

tushar5526 commented May 22, 2024

For a project's docker-compose as specified.

services:
  app: 
     image: ..
     ports:
        - ${PORT:-3000}:3000

compose file should be converted to a processed compose file using docker-compose config after loading the environment variables from Vault and then it should be processed further.

@Amandeepsingh25
Copy link

Amandeepsingh25 commented May 25, 2024

I'm eager to contribute and resolve the Docker Compose port variable issue.I would like to contribute to sarthi.Please assign me this issue @tushar5526

@GJS2162
Copy link

GJS2162 commented May 25, 2024

Hi Tushar,

I would like to take on this task of adding support to allow ports as variables in the Docker Compose file (#46). I have experience working with Docker and Docker Compose, and I believe I can implement this feature efficiently.

Please assign this task to me.

Thank you!

Best regards,
Gaurav Ji Srivastava

@Amandeepsingh25
Copy link

#53

@tushar5526
Copy link
Owner Author

Hey @Amandeepsingh25 @GJS2162 great first try but I think there was a miss on my end to explain the problem statements in a better way.

First of all I wanted to know were your folks able to setup the project locally ?

@Amandeepsingh25
Copy link

@tushar5526 yes I have run the docker compose file locally but fail to unerstand the endpoint for knowing the output .

@tushar5526
Copy link
Owner Author

@Amandeepsingh25 check out the contributor's guide in the readme.

@GJS2162
Copy link

GJS2162 commented Jun 3, 2024

Hey @Amandeepsingh25 @GJS2162 great first try but I think there was a miss on my end to explain the problem statements in a better way.

First of all I wanted to know were your folks able to setup the project locally ?

Sorry for the late reply.

Initially, I reviewed the documentation to understand how to run the project. However, I decided to proceed directly with the task at hand. I will give it a try, and if I encounter any issues or need assistance, I will reach out for help.

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants