Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Question] Authentication for HEAD / PATCH #1117

Closed
blmhemu opened this issue Apr 21, 2024 · 2 comments
Closed

[Question] Authentication for HEAD / PATCH #1117

blmhemu opened this issue Apr 21, 2024 · 2 comments
Labels

Comments

@blmhemu
Copy link
Contributor

blmhemu commented Apr 21, 2024

Question
Thanks for moving the industry forward on the resumable uploads - tusd's hooks are well designed and quite useful.

The documentation mentions limited support for upload authentication.

Currently, there is no mechanism to ensure that the upload is resumed by the same user that created it.

This could be fine if the file urls are non-deterministic. But if we want to make the URL path deterministic, (say to avoid storing state at client side), then this assumption would not hold.

Is there a 'hook' for validating the PATCH and HEAD requests ? Can this be achieved programmatically with go middlewares ?

Alternatively, can we add "validate" hook for every type of request ?

Random Suggestion
https://tus.github.io/tusd has really good documentation and should be referenced (frequently / significantly) at tus.io

@blmhemu blmhemu changed the title [Question] Authentication [Question] Authentication for HEAD / PATCH Apr 21, 2024
@Acconut
Copy link
Member

Acconut commented Apr 23, 2024

Work for such a hook, that checks access to an upload resource, has already began in #1077. You can find a bit more context in #669 (comment) and I hope that we can finish the PR soon.

@blmhemu
Copy link
Contributor Author

blmhemu commented Apr 23, 2024

Awesome ! PR looks good (similar to what I mentioned, but in code) ! Please feel free to close this issue. ❤️

@Acconut Acconut closed this as completed Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants