Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[S3Store] 0 bytes files are not uploaded #602

Open
fenos opened this issue Apr 18, 2024 · 1 comment
Open

[S3Store] 0 bytes files are not uploaded #602

fenos opened this issue Apr 18, 2024 · 1 comment

Comments

@fenos
Copy link
Collaborator

fenos commented Apr 18, 2024

Hello,
Currently, it seems that 0 bytes files don't make it to S3.
the .info file is written correctly and the request succeeds but no files are present on the S3 Bucket.

I guess there is a bug on the StreamSplitter but I yet need to do further investigation.
Feel free to look at this too as it might take me sometime
@Murderlon
Copy link
Member

Posting how tusd handles it for my own reference later:

https://github.com/tus/tusd/blob/15f05c021c9770dc0cd2818aa4ef44b9e361f5b2/pkg/s3store/s3store.go#L839-L862

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fenos @Murderlon