Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GSC Datastore does not support "contentType" property #57

Open
joshbeal opened this issue Nov 9, 2016 · 4 comments
Open

GSC Datastore does not support "contentType" property #57

joshbeal opened this issue Nov 9, 2016 · 4 comments

Comments

@joshbeal
Copy link

joshbeal commented Nov 9, 2016

There should be a way to set contentType on the uploaded object as such...

var stream = file.createWriteStream({
metadata: {
contentType:
}
});

@bhstahl
Copy link
Contributor

bhstahl commented Nov 17, 2016

Hey @joshbeal, what is passed through in the Upload Metadata header (as per the protocol) is set on the GCS Object.

Will that suffice for your usage? If not, feel free to send over a PR with some code to discuss. Thanks for using tus!

@edwar64896
Copy link

I'm noticing that when completing an upload using a GCS datastore, that there is no metadata passed to the completion event at all. metadata: {} is all I see. any idea if this is related?

@tkrugg
Copy link

tkrugg commented Aug 18, 2018

As of now, upload_metadata is just injected as a key of the metadata
So it offers no way to update the contentType, which is another key, as you can tell by the screenshot

screenshot at aug 18 15-21-51

we'd need something like, and then there's maybe a way to update the contentType

metadata: {
...metadata_upload
}

The only work around right now is to call setMetadata method on the google cloud storage api, when upload is done.

@Acconut
Copy link
Member

Acconut commented Aug 20, 2018

@tkrugg Would you mind opening a PR for this?

tkrugg added a commit to tkrugg/tus-node-server that referenced this issue Aug 23, 2018
tkrugg added a commit to tkrugg/tus-node-server that referenced this issue Aug 23, 2018
tkrugg added a commit to tkrugg/tus-node-server that referenced this issue Aug 23, 2018
tkrugg added a commit to tkrugg/tus-node-server that referenced this issue Oct 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants