Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Part of the source code is missing when adding the SDK via cocoapods #116

Open
thinium opened this issue Aug 4, 2016 · 3 comments
Open

Comments

@thinium
Copy link

thinium commented Aug 4, 2016

I am trying to add TMTumblrSDK into my project using cocoapods. This is what I have in my pod file:

platform :ios, '7.0'

target 'PhotoPostExample' do

pod 'TMTumblrSDK', '~> 4.0.4'

end

I set the SDK version to 4.0.4 based on the info here
https://github.com/tumblr/TMTumblrSDK/blob/master/TMTumblrSDK.podspec.json

But the TMAPIClient.h looks very different, the following secion is missing:

#ifdef __ENVIRONMENT_IPHONE_OS_VERSION_MIN_REQUIRED__

/**
 Authenticate via three-legged OAuth using a given UIWebView

 Your `TMAPIClient` instance's `handleOpenURL:` method must also be called from your `UIApplicationDelegate`'s
 `application:openURL:sourceApplication:annotation:` method in order to receive the tokens.

 This method proxies to an underlying `TMTumblrAuthenticator` which will authenticate using the given the web view.
 That class can be used on its own but you do not need to invoke it directly if you are including the whole API client in your project.

 @param URLScheme a URL scheme that your application can handle requests to.

 @param fromViewController a UIViewController to present the authentication view controller from.
 */
- (void)authenticate:(NSString *)URLScheme fromViewController:(UIViewController *)fromViewController callback:(void(^)(NSError *))error;

#endif

Any idea what I can do to fix this? Thanks!

@thinium thinium changed the title SDK Version? Part of the source code is missing when adding the SDK via cocoapods Aug 4, 2016
@Pearapps
Copy link
Contributor

Pearapps commented Aug 4, 2016

These will be available after we push a new version to cocoapods trunk!

Thank you for your interest in TMTumblrSDK - we will update this thread once we do so

@thinium
Copy link
Author

thinium commented Aug 4, 2016

I see, thanks for the reply!

Meanwhile, is there a way for me to integrate the SDK (without too much pain)? Or I should simply wait for the update?

@paulrehkugler
Copy link
Contributor

If you need to integrate it right now, you can depend on the most recent commit in the repo. However, I would recommend updating your Podfile to a stable version once a published version of the SDK meets your needs, because we will inevitably push backwards-incompatible API changes to this repo.

pod 'TMTumblrSDK', :head

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants