Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Equations and Code Matching Issue #21

Open
JingliSHI0206 opened this issue Mar 10, 2021 · 1 comment
Open

Equations and Code Matching Issue #21

JingliSHI0206 opened this issue Mar 10, 2021 · 1 comment

Comments

@JingliSHI0206
Copy link

Hi,

First, i cannot figure out what is the real meaning of h_w1 and h_w2 in the paper. author never gives a description of them based on the below equation.
image

then, I start to search them in code, and I find they are totally same. please correct me if I'm wrong. the calculation of S(w1, r, w2) uses the below code.

image

however, both trs0_rel and trs1_rel are linear functions with same dimension. same input are passed to them and i think the output should be also same.

self.trs0_rel = nn.Linear(self.hid_size2, self.hid_size)
self.trs1_rel = nn.Linear(self.hid_size
2, self.hid_size)

so my question is, if one linear function is enough, why two are listed with different notations?

any explanations are greatly appreciated. thank you

@Junzizaiji
Copy link

Hello, I would like to know where the three learnable relationship matrices are represented in the code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants