Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Account SIGN_IN #119

Open
wtavares opened this issue Oct 11, 2019 · 4 comments
Open

Account SIGN_IN #119

wtavares opened this issue Oct 11, 2019 · 4 comments

Comments

@wtavares
Copy link

wtavares commented Oct 11, 2019

Hi !

Does we have the account sign_in response in order to request to the assistant start the sign in?

https://developers.google.com/assistant/conversational/helpers#account_sign-in

If not... how do I can implement this by myself an contribute with the project? I'm thinking in to something similar to the permission class. But as I'm not a python expert I do not how exactly how to do.

Thanks in advance.
W

@treethought
Copy link
Owner

hi @wtavares. flask-assistant now supports Account linking via Google Sign in!

To update: pip installl -U flask-assistant

and then check out the account linking example

@wtavares
Copy link
Author

Hi @treethought !!!!

Thanks a lot for the fast feedback. Implemented and tested yesterday. Worked like a charm!

One comment and one question:

Comment: The profile and the access_token are not been filled. They are None. There is any trick or init needed? The user dict has all user sent by the DF including the access_token. I'm using it. No problem to me once I'm using my own OAuth2 implementation and validations to build the profile.

The doubt: How to we unlink or invalidate the access_token ate the AoG???? If my user removes their account... the token info is not useful anymore. So... is necessary to "invalidate" or remove the token at AoG. Do you have any idea about how to do this?

Thanks again!
W

@treethought
Copy link
Owner

Hi @wtavares, currently only Google Sign in is supported. Sounds like you are talking about the access token that is received during OAuth sign in. When using google sign in, you don't receive an access token, but rather a JWT token that is decoded to obtain the profile information.

And do you mean the profile local (imported from flask_assistant) is None after a user signs in?

@wtavares
Copy link
Author

wtavares commented Oct 25, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants