#14 Fix notecard serial error #15
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… captured_at at post time
Comment on lines
-90
to
-102
| # Tuning factor for compensation. Decrease this number to adjust the | ||
| # temperature down, and increase to adjust up | ||
| raw_temp = bme280.get_temperature() | ||
|
|
||
| if factor: | ||
| cpu_temps = [get_cpu_temperature()] * 5 | ||
| cpu_temp = get_cpu_temperature() | ||
| # Smooth out with some averaging to decrease jitter | ||
| cpu_temps = cpu_temps[1:] + [cpu_temp] | ||
| avg_cpu_temp = sum(cpu_temps) / float(len(cpu_temps)) | ||
| temperature = raw_temp - ((avg_cpu_temp - raw_temp) / factor) | ||
| else: | ||
| temperature = raw_temp |
There was a problem hiding this comment.
@sighmon what's your idea about changing this to a more basic approach?
There was a problem hiding this comment.
@tijmenvandenbrink It wasn't working out linearly across the temperature range for me and also didn't take into account the humidity changes from the extra heat. My simplistic version isn't great either, so I'll keep working on it.
|
@sighmon seems to have some conflicts before I can merge them. Would you care to fix them and I will merge the changes. Thanks for your contribution! |
|
@tijmenvandenbrink Sorry, I didn't mean to open this in your repo - I'm still playing around with a few things here, so I'll create a fresh PR when it's ready. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #14
SerialErrorwhen trying to post to Notecard