Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hesai hesai_cmd_response.hpp struct formats are wrong for some sensors #130

Open
mojomex opened this issue Mar 28, 2024 · 0 comments
Open
Labels
bug Something isn't working

Comments

@mojomex
Copy link
Collaborator

mojomex commented Mar 28, 2024

Structs such as HesaiConfig and HesaiLidarMonitor are not correct e.g. for OT128: its datasheet lists different fields and packet lengths. The data is parsed into them anyway, so the contents are definitely wrong (the first few fields are largely correct) and segfaults might occur when PTC response size != struct size.

@mojomex mojomex self-assigned this Mar 28, 2024
@mojomex mojomex added the bug Something isn't working label Mar 28, 2024
@mojomex mojomex removed their assignment Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant