Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

migrate randomness #6

Open
thor314 opened this issue Nov 1, 2023 · 2 comments
Open

migrate randomness #6

thor314 opened this issue Nov 1, 2023 · 2 comments
Labels
good first issue Good for newcomers implementation

Comments

@thor314
Copy link
Owner

thor314 commented Nov 1, 2023

migrate randomness. Relatively small part of the code-base, will rely on finding a decent blake2 hashing library.
@agnxsh
Copy link

agnxsh commented Nov 2, 2023 •
edited
Loading

https://docs.rs/blake2/latest/blake2/ for blake, any thoughts on this?
https://docs.rs/blake2/latest/blake2/type.Blake2s256.html also this is a similar type to https://github.com/starkware-libs/stone-prover/blob/main/src/starkware/crypt_tools/blake2s.inl#L93-L101 as far i can understand for now

@thor314
Copy link
Owner Author

thor314 commented Nov 2, 2023

That seems reasonable, it would also be good to keep the randomness generator generic over the hash function of choice, so that we may potentially support other hashes in the future if you'd like to tackle that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers implementation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@thor314 @agnxsh