Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore secondary_index test #32

Open
ptagl opened this issue Sep 11, 2024 · 0 comments
Open

Restore secondary_index test #32

ptagl opened this issue Sep 11, 2024 · 0 comments
Labels
enhancement New feature or request
Milestone

Comments

@ptagl
Copy link
Contributor

ptagl commented Sep 11, 2024

Overview

This commit removed a test to check the management of secondary keys in smart contract tables.
The test was initially meant to test a specific scenario: the SNARKtor Testnet contract compiled to WASM.
The problem is that WASM contracts (compiled using rscdk) treat the Checksum256 with a different encoding compared to the C++ compiler.

For this reason, antelope-rs has been made compatible with the C++ encoding and the test has been removed.

The test should be added again once the issue has been solved. This may require a fork of the rscdk to fix the encoding mentioned above, and a new deployment of the SNARKtor contract(s).

Links

  • Commit that removed the test: 598dd54
  • Revert commit that fixed the Checksum256 encoding to be compatible with C++ smart contracts (and not with WASM contracts anymore): 02d0e7e
  • Initial commit that introduced the Checksum256 encoding compatible with WASM smart contracts (but not with C++ ones): 6977b8b

Acceptance Criteria

  • A secondary_index test is available again in the codebase
  • The test passes
@ptagl ptagl added the enhancement New feature or request label Sep 11, 2024
@ptagl ptagl added this to the [M1] milestone Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant