Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flag config about backend_cache never used by sinks #2264

Open
AlvaroVega opened this issue Jun 14, 2023 · 7 comments
Open

flag config about backend_cache never used by sinks #2264

AlvaroVega opened this issue Jun 14, 2023 · 7 comments

Comments

@AlvaroVega
Copy link
Member

flag config about backend cache is defined by never usded by sinks (i.e. SQL sinks)

@kumardeepak5
Copy link
Contributor

Hi @AlvaroVega,

can i have more info about flag mentioned in issue? so that i can start with same.
I have tried to find flag (backend_cache) in source code but could not found same flag in source code.

@AlvaroVega
Copy link
Member Author

AlvaroVega commented May 16, 2024

This is the flag

protected boolean getEnableCache() {
return enableCache;
} // getPostgreSQLHost

But I'm not sure it should be removed or just used

@fgalan
Copy link
Member

fgalan commented May 16, 2024

@kumardeepak5 is that flag useful for your use case?

@kumardeepak5
Copy link
Contributor

HI @fgalan
Thanks for your reply.

Below is reply for your query
> is that flag useful for your use case?

I just started to contribute for this open issue.

Further i just investigated in source code & documentation and below are my findings -

  1. Same flag is not in use any where although it is mentioned in the docs also.
    Places where it is mentioned are - ngsi-orion-sink and ngsi-postgresql-sink

My Queries-
Is it Planned to use same flag in future? If Yes please let me know the purpose of this flag?
Or is it required to remove same flag from documentation and code?

@fgalan
Copy link
Member

fgalan commented May 16, 2024

Per @AlvaroVega comment

But I'm not sure it should be removed or just used

it seems we are not sure about investing effort in fixing this, specially if no use case is behind it (that's why ask you about it).

Thus, if you don't have a use case for that, I'd suggest to pick another more profitable issue to address.

What do you think?

@kumardeepak5
Copy link
Contributor

kumardeepak5 commented May 16, 2024

I just checked FILE SQLCache File.
It is working as in-memory cache which is not suitable for distributed ENV, so we can allow user to switch On-Off in memory cache in that case.

May be at this place we can use this flag?

@fgalan
Copy link
Member

fgalan commented May 17, 2024

May be at this place we can use this flag?

Ok, go ahead and propose a PR with the fix, please. We would have a look to it. Thanks in advance!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants