Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

whisper-rs-sys is likely compiled without AVX support #78

Closed
marmistrz opened this issue Aug 11, 2023 · 4 comments · Fixed by #85
Closed

whisper-rs-sys is likely compiled without AVX support #78

marmistrz opened this issue Aug 11, 2023 · 4 comments · Fixed by #85

Comments

@marmistrz
Copy link
Contributor

The fix is proposed here: ggerganov/whisper.cpp#1174

@tazz4843
Copy link
Owner

Given how long it's been since an upstream release I'm probably just going to end up picking the latest git master and making a new release.

@marmistrz
Copy link
Contributor Author

marmistrz commented Aug 21, 2023

Strangely enough, I looked more closely into this, and even though whisper.cpp itself was compiled without AVX, I can't reproduce it with whisper-rs. Would it make some sense to add AVX detection into the tests (with an informative error message that "if your hardware doesn't support AVX, disable the test"?)

@tazz4843
Copy link
Owner

whisper-rs currently doesn't have any tests for much functionality since bundling a model with every test is somewhat painful for what's just a thin wrapper. If you wanted to add some though, by all means feel free to do so.

@tazz4843
Copy link
Owner

See #85

@tazz4843 tazz4843 linked a pull request Aug 28, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants