Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Play episode button active state not synced with player active state #1338

Open
mrbotmd opened this issue Nov 2, 2023 · 4 comments
Open
Assignees
Milestone

Comments

@mrbotmd
Copy link

mrbotmd commented Nov 2, 2023

When i pause, or pause and close player, or close player the button still displaying as if episode is being played.
image
This issue is probably related to #1195 due to playback not stopping on player close.

I think if playing episode button state is tied to player active state, that would resolve the issue.

@stolinski
Copy link
Collaborator

I'll fix as a part of my player upgrade branch.

@stolinski stolinski added this to the Project Picnic milestone Dec 11, 2023
@stolinski stolinski self-assigned this Dec 11, 2023
@stolinski
Copy link
Collaborator

This is now partially fixed. However, it doesn't stop when paused just when stopped so I'll have to tweak.

@stolinski stolinski modified the milestones: Project Picnic, 2.1 Jun 27, 2024
@w3cj
Copy link
Member

w3cj commented Aug 8, 2024

This looks to be fixed by the recent player work that @stolinski did. @mrbotmd can you confirm?

@stolinski
Copy link
Collaborator

This was not actually fixed for whatever reason.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants