Skip to content
This repository has been archived by the owner on Jul 24, 2024. It is now read-only.

Duplicate extensions can be achieved when importing integrations #5420

Closed
mmuzikar opened this issue May 20, 2019 · 3 comments
Closed

Duplicate extensions can be achieved when importing integrations #5420

mmuzikar opened this issue May 20, 2019 · 3 comments
Assignees
Labels
cat/bug A bug which needs fixing closed/verified Used by QE to indicate that verified the issue prio/p1 The priority of a bug. p1 means high source/qe Raised by QE

Comments

@mmuzikar
Copy link
Contributor

This is a...


[ ] Feature request
[ ] Regression (a behavior that used to work and stopped working in a new release)
[x] Bug report  
[ ] Documentation issue or request

Description

Relates to #5163
Multiple extensions of the same extensionId shouldn't be present in Syndesis at the same time, but the importing process ignores this restriction and the user usually ends up with duplicates of the same extension, which can be only resolved by deleting both integrations and related extension (you have to delete both integrations to be able to delete the duplicate extension).

Steps to reproduce:

  1. import set body extension
  2. import integration using set body extension

What is also interesting is if you remove both extensions and then import the integration you end up with having two integrations in Syndesis.

Another way to achieve this is by having two different integrations (importing the same integration twice only overwrites the original integration) which also causes this behavior.

@mmuzikar mmuzikar added cat/bug A bug which needs fixing prio/p1 The priority of a bug. p1 means high source/qe Raised by QE labels May 20, 2019
@pure-bot pure-bot bot added the notif/triage The issue needs triage. Applied automatically to all new issues. label May 20, 2019
@mmuzikar
Copy link
Contributor Author

Adding link to sample integrations to reproduce: https://drive.google.com/open?id=1rx8xAZXAHlA2Ng0lPy2q_JXPGZ7FZkXV

@heiko-braun heiko-braun removed the notif/triage The issue needs triage. Applied automatically to all new issues. label May 23, 2019
@heiko-braun heiko-braun added this to the Sprint 47 (3/4) milestone May 28, 2019
@dhirajsb
Copy link
Contributor

This was a tricky issue and extensions import in integrations had to be rewritten to ignore ids altogether and use extensionIds and versions.
I've added logic to compare extension maven versions to take the most recent version, either updating the syndesis instance or the imported integration appropriately.
@mmuzikar please test PR #5735 with this use case and any other use cases you can think of?

@pure-bot pure-bot bot closed this as completed in 0875175 Jun 14, 2019
@pure-bot pure-bot bot locked as resolved and limited conversation to collaborators Jun 14, 2019
@pure-bot pure-bot bot reopened this Jun 14, 2019
@pure-bot pure-bot bot unlocked this conversation Jun 14, 2019
@mmuzikar mmuzikar added the closed/verified Used by QE to indicate that verified the issue label Jun 20, 2019
@mmuzikar
Copy link
Contributor Author

@dhirajsb can't think of other use cases when this might be a problem. I checked with multiple integrations and everything works as it should, you just saved me a lot of headaches when preparing tests using extensions, thanks :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cat/bug A bug which needs fixing closed/verified Used by QE to indicate that verified the issue prio/p1 The priority of a bug. p1 means high source/qe Raised by QE
Projects
None yet
Development

No branches or pull requests

3 participants