Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Service Endpoints Use #1

Open
calebcartwright opened this issue Feb 12, 2018 · 2 comments
Open

Allow Service Endpoints Use #1

calebcartwright opened this issue Feb 12, 2018 · 2 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Issue or PR needs someone to work on it!

Comments

@calebcartwright
Copy link
Member

We should allow the task configuration to point to existing service endpoints for specifying the git repo and authentication info (for example the GitHub and Bitbucket service endpoints).

This would provide an option for folks to use existing connections.

@calebcartwright calebcartwright added enhancement New feature or request needs discussion Requires more discussion before work can continue/begin labels Feb 12, 2018
@traviskosarek
Copy link
Member

I agree. I think this would be a good thing to add. It makes a lot sense.

In terms of endpoints, I think we can support some of the already existing service endpoints (I'm thinking Github specifically), but should we also include a Generic Git service endpoint with the task?

And if we do that, would that completely replace the "in task" repository endpoint, or would that just be another option?

I know we can do it either way, but I want to hear other opinions before I go do it ;)

@calebcartwright
Copy link
Member Author

calebcartwright commented Feb 14, 2018

It may not make sense to do them all at once (can add support incrementally), but I would think we should support all of them eventually.

All VSTS accounts should automatically and already have existing Service Endpoint types for GitHub, Bitbucket, as well as a generic Git endpoint type, so I don't think we'll have to make a custom endpoint type.

[Edit - fixed minor typos]

@calebcartwright calebcartwright added help wanted Issue or PR needs someone to work on it! good first issue Good for newcomers and removed needs discussion Requires more discussion before work can continue/begin labels Jan 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Issue or PR needs someone to work on it!
Projects
None yet
Development

No branches or pull requests

2 participants