Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Redis fallback ack_deadline_ms does not work as expected #102

Open
jaymell opened this issue Sep 4, 2024 · 0 comments
Open

Bug: Redis fallback ack_deadline_ms does not work as expected #102

jaymell opened this issue Sep 4, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@jaymell
Copy link
Contributor

jaymell commented Sep 4, 2024

This setting does not work as expected. The issue is that when messages are received, they are moved from the main queue to the processing queue without updating their ID, so that a message will potentially be re-enqueued based on the time it was created rather than the time it was last received.

This has the potential to result in duplicate messages and/or messages that are re-queued too soon if they are not acked within ack_deadline_ms from the time they were originally enqueued.

Currently we do an atomic BRPOPLPUSH in order to move items from the main queue to the processing queue. We will probably need a non-atomic solution that involves popping a message and enqueuing it into the processing queue with a new ID if we want to fix this.

@svix-jplatte svix-jplatte added the bug Something isn't working label Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants