New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Year Observed holiday #173

Open

karkeedaniel opened this issue Jan 23, 2023 · 0 comments

karkeedaniel commented Jan 23, 2023

I have the following configuration for New Year Holiday.

<tns:Fixed month="JANUARY" day="1" descriptionPropertiesKey="NEW_YEAR">
  <tns:MovingCondition substitute="SATURDAY" with="PREVIOUS" weekday="FRIDAY" />
  <tns:MovingCondition substitute="SUNDAY" with="NEXT" weekday="MONDAY" />
</tns:Fixed>

Since 01/01/2022 (New Year) is on Saturday the holiday observed should be on 12/31/2021 (Friday). The above configuration does not work.

I have tested the same configuration for Independence Day and it works as expected.

<tns:Fixed month="JULY" day="4" validFrom="1776" descriptionPropertiesKey="INDEPENDENCE">
  <tns:MovingCondition substitute="SATURDAY" with="PREVIOUS" weekday="FRIDAY" />
  <tns:MovingCondition substitute="SUNDAY" with="NEXT" weekday="MONDAY" />
</tns:Fixed>

The text was updated successfully, but these errors were encountered:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment