-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
frizbee actions
generates wrong/invalid commit ref?
#206
Comments
Minimal reproducer:
|
GitHub's own API endpoints appear to be returning the wrong ref here:
yields: {
"node_id": "REF_kwDOMnghHqxyZWZzL3RhZ3MvdjM",
"object": {
"sha": "c5df01c9e4233fcd789bd004850aa36809d07727",
"type": "tag",
"url": "https://api.github.com/repos/astral-sh/setup-uv/git/tags/c5df01c9e4233fcd789bd004850aa36809d07727"
},
"ref": "refs/tags/v3",
"url": "https://api.github.com/repos/astral-sh/setup-uv/git/refs/tags/v3"
} ...and
yields: {
"node_id": "TA_kwDOMnghHtoAKGM1ZGYwMWM5ZTQyMzNmY2Q3ODliZDAwNDg1MGFhMzY4MDlkMDc3Mjc",
"sha": "c5df01c9e4233fcd789bd004850aa36809d07727",
"url": "https://api.github.com/repos/astral-sh/setup-uv/git/tags/c5df01c9e4233fcd789bd004850aa36809d07727",
"tagger": {
"name": "eifinger",
"email": "[email protected]",
"date": "2024-10-25T12:13:43Z"
},
"object": {
"sha": "3b9817b1bf26186f03ab8277bab9b827ea5cc254",
"type": "commit",
"url": "https://api.github.com/repos/astral-sh/setup-uv/git/commits/3b9817b1bf26186f03ab8277bab9b827ea5cc254"
},
"tag": "v3",
"message": "Release v3.2.0\n",
"verification": {
"verified": false,
"reason": "unsigned",
"signature": null,
"payload": null
}
} |
another idea is probably we just query /tags endpoint
|
Hi @woodruffw, thank you for the thorough investigation and the reproducer, this is awesome! I'll try to have a better look later this week, possibly early next week. |
Hacks around stacklok/frizbee#206. Signed-off-by: William Woodruff <[email protected]>
Describe the issue
Hi there! Thanks for
frizbee
, it's an awesome tool.@chenrui333 ran
frizbee
onzizmor
here: woodruffw/zizmor#90 and it produced a strange (seemingly nonexistent) pinned commit ref.In particular, this:
became this:
However, that commit (
c5df01c9e4233fcd789bd004850aa36809d07727
) doesn't appear to exist at all, either on the upstream or anywhere in the fork network: astral-sh/setup-uv@c5df01cI think the correct ref here should be
3b9817b1bf26186f03ab8277bab9b827ea5cc254
, corresponding to tagsv3
andv3.2.0
: https://github.com/astral-sh/setup-uv/releases/tag/v3.2.0To Reproduce
To reproduce, run
frizbee actions .github/workflows
on https://github.com/woodruffw/zizmor and observe the ref 🙂frizbee version
output:What version are you using?
v0.1.4
The text was updated successfully, but these errors were encountered: