Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Forgot .add #14

Open
thomcom opened this issue Oct 14, 2022 · 3 comments
Open

Forgot .add #14

thomcom opened this issue Oct 14, 2022 · 3 comments

Comments

@thomcom
Copy link

thomcom commented Oct 14, 2022

Hiya! I'm noticing that gl-matrix.mat4 and the docs have the .add function, but here it does not. Was it forgotten? Thanks!
@rreusser rreusser mentioned this issue Oct 14, 2022
Merged
@rreusser
Copy link
Member

rreusser commented Oct 14, 2022 •
edited
Loading

Good point. It looks to me like they may have just been missed, so I submitted #15 and added sub() as well. There are no tests in place so that I…… haven't actually run the functions… but I mean… it's hard to mess these up…… right? 😬 If it looks good to you, then I can merge and try to get this published.

@thomcom
Copy link
Author

thomcom commented Oct 14, 2022

Nice, that was fast! Looks good to me.

@rreusser
Copy link
Member

It's all set and merged to master, except I don't have npm credentials on me at the moment, so I'll have to publish later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@thomcom @rreusser