Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider using URLs to assets that are unique per version #247

Open
rwinch opened this issue May 17, 2024 · 0 comments
Open

Consider using URLs to assets that are unique per version #247

rwinch opened this issue May 17, 2024 · 0 comments

Comments

@rwinch
Copy link
Collaborator

rwinch commented May 17, 2024

Instead of having an asset of site.css perhaps we could use something like site-{checksum}.css or site-{git-sha1}.css This would ensure we didn't need to bust caches.

Alternatively we could potentially write the links using something like: site.css?v={checksum} or site.css?v={git-sha1}. The advantage of this approach is it would likely be very easy since we already include the git version for antora-ui-version and we would just need to place @@antora-ui-version in the templates next to any existing URLs. The disadvantage is that we may be moving our hosting platform which I'm not sure if it supports query strings on assets.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant