Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem with the product image thumbnail #193

Open
hendra opened this issue Aug 28, 2022 · 0 comments
Open

Problem with the product image thumbnail #193

hendra opened this issue Aug 28, 2022 · 0 comments

Comments

@hendra
Copy link

hendra commented Aug 28, 2022

I found two problems with the product image thumbnail at the page /admin/products/:slug/images :

  1. The thumbnail image size would be better to use mini_image instead of product_image, this will increase the performance of the page load especially when the product has many images.
  2. The CSS thumbnail image transformation makes the displayed image not full, would be better if the image can be displayed full fit.

From this :

Spree-Administration-Images

To :

Spree-Administration-Images (1)

I already created PR to solve the problems above here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant