Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only include "completed" payments? #101

Open
naw opened this issue Nov 27, 2015 · 2 comments
Open

Only include "completed" payments? #101

naw opened this issue Nov 27, 2015 · 2 comments
Labels
enhancement

Comments

@naw
Copy link

naw commented Nov 27, 2015

The invoice template displays all payments for an order, even invalid or failed ones.

As a new user to this gem, I would have expected only "completed" payments to be displayed in the invoice PDF by default.

WDYT?
@tvdeyen
Copy link
Contributor

tvdeyen commented Nov 27, 2015

Seams reasonable. We override the default templates in our projects, so we don't know of any issues being in the defaults.

Please send a pull request that fixes this.
Thanks

@mdavo6 mdavo6 mentioned this issue Apr 26, 2018
Merged
@mdavo6
Copy link
Contributor

mdavo6 commented Apr 29, 2021

@damianlegawiec This issue can be closed, as was resolved by PR #125

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tvdeyen @naw @mdavo6