Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WiFi Config - Base Configuration - NTRIP Server (1) - Save Configuration fails... #480

Open
PaulZC opened this issue Sep 25, 2024 · 4 comments

Comments

@PaulZC
Copy link
Contributor

PaulZC commented Sep 25, 2024

Reported here and here.

We have a gremlin in main.js when using checkElementString on the NTRIP Server (1) configuration:

image

Investigating...

@PaulZC
Copy link
Contributor Author

PaulZC commented Sep 25, 2024

This issue has already been resolved in the release_candidate branch...

I've created a separate "hotfix" branch which includes: the fix for this issue; and increases the number of corrections sources to 8.

https://github.com/sparkfun/SparkFun_RTK_Everywhere_Firmware/commits/Hotfix_%23480/

@PaulZC
Copy link
Contributor Author

PaulZC commented Sep 25, 2024

@nseidle : this is done. Please release an RC from the Hotfix branch when time permits.

@PaulZC
Copy link
Contributor Author

PaulZC commented Sep 25, 2024

I suggest we don't merge the Hotfix branch into main. It is safe to do so, the changes should be identical to the changes already in release_candidate, but they'll probably appear as a conflict...

@nseidle
Copy link
Member

nseidle commented Sep 25, 2024

Nice fix! RC has been posted Sep-25.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants