Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Difference between C++ and Go output #11

Open
panamafrancis opened this issue Mar 2, 2016 · 1 comment
Open

Difference between C++ and Go output #11

panamafrancis opened this issue Mar 2, 2016 · 1 comment

Comments

@panamafrancis
Copy link

I've been running both the C++ and this version of Murmur3 side by side and i've noticed that in cases where a null byte occurs in the middle of the input data, the C++ version will output a different hash.

Now I guess this is a bug in the C++ implementation, as Go will iterate over the correct array length, and not just stop at a null byte. But, given that the C++ version is the "official" one, should this version implement the bug as a feature?

@spaolacci
Copy link
Owner

Well, I doubt there's a bug in the original implementation ;), but I could use a reproducer (with the C++ version you're using).

I would suspect an API misusage given the C/C++ null byte specific signification.

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants