SNOW-1805438: BuildResultSet >> NullReferenceException

[GSerjo]

Please answer these questions before submitting your issue.
In order to accurately debug the issue this information is required. Thanks!

1. What version of .NET driver are you using?
   <PackageReference Include="Snowflake.Data" Version="4.2.0" />

2. What operating system and processor architecture are you using?
   windows x64

3. What version of .NET framework are you using?
   net8.0

4. What did you do?
   called ExecuteNonQueryAsync(cancellationToken); on DbCommand

5. What did you expect to see?
   Descriptive error message: what was wrong. The current driver's implementation throws a null reference exception.

6. Can you set logging to DEBUG and collect the logs?

here's call stack

System.NullReferenceException: Object reference not set to an instance of an object.
   at Snowflake.Data.Core.SFStatement.BuildResultSet(QueryExecResponse response, CancellationToken cancellationToken)
   at Snowflake.Data.Core.SFStatement.GetResultWithId(String resultId)
   at Snowflake.Data.Core.SFMultiStatementsResultSet.NextResult()
   at Snowflake.Data.Core.SFMultiStatementsResultSet..ctor(QueryExecResponseData responseData, SFStatement sfStatement, CancellationToken cancellationToken)
   at Snowflake.Data.Core.SFStatement.BuildResultSet(QueryExecResponse response, CancellationToken cancellationToken)
   at Snowflake.Data.Core.SFStatement.ExecuteAsync(Int32 timeout, String sql, Dictionary`2 bindings, Boolean describeOnly, Boolean asyncExec, CancellationToken cancellationToken)
   at Snowflake.Data.Client.SnowflakeDbCommand.ExecuteNonQueryAsync(CancellationToken cancellationToken)

Looks like the response is null somehow

private SFBaseResultSet BuildResultSet(
      QueryExecResponse response,
      CancellationToken cancellationToken)
    {
      if (response.data != null && response.data.queryId != null)
        this._lastQueryId = response.data.queryId;
      if (!response.success)
        throw new SnowflakeDbException(response.data.sqlState, response.code, response.message, response.data.queryId);
      if (response.data.resultIds != null && response.data.resultIds.Length > 0)
        return (SFBaseResultSet) new SFMultiStatementsResultSet(response.data, this, cancellationToken);
      return response.data.queryResultFormat == ResultFormat.ARROW ? (SFBaseResultSet) new ArrowResultSet(response.data, this, cancellationToken) : (SFBaseResultSet) new SFResultSet(response.data, this, cancellationToken);
    }

Based on the call stack, here's what has been called before the exception

public T Get<T>(IRestRequest request)
    {
      return Task.Run<T>((Func<Task<T>>) (async () => await this.GetAsync<T>(request, CancellationToken.None).ConfigureAwait(false))).Result;
    }

    public async Task<T> GetAsync<T>(IRestRequest request, CancellationToken cancellationToken)
    {
      T async;
      using (HttpResponseMessage response = await this.GetAsync(request, cancellationToken).ConfigureAwait(false))
        async = JsonConvert.DeserializeObject<T>(await response.Content.ReadAsStringAsync().ConfigureAwait(false), JsonUtils.JsonSettings);
      return async;
    }

Don't know the exact command's query params. It would be nice if the connector will catch the exception and provide some details on what was wrong.

[sfc-gh-dszmolka]

hi - thanks for reporting this issue and the analysis ! we'll take a look

[sfc-gh-dszmolka]

fix in review: #1061
edit: PR is already merged; thus will be part of the next driver release