Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some missing files and inability to find others #202

Closed

Conversation

lucyllewy
Copy link
Member

@lucyllewy lucyllewy commented Aug 21, 2022

  • Add some extra layout definitions for gimp to find some platform executables and shared files
  • Update the environment: block for runtime search paths that are missing in the platform snap's desktop-launch script
  • Add missing libva-drm and libva-x11 libraries
  • Ensure gimp is built as a relocatable executable so that it can find some of its assets easier in the snap
  • Move the debug symbols compiler flags to use the configure script's support
  • Add missing iso-codes because gimp refuses to look for them anywhere but $SNAP/usr/share/xml/iso-codes
  • Add missing lua-lgi for gimp's lua scripting capability
  • Fix the cleanup part to not delete the iso-codes we're including in the snap directly

Signed-off-by: Dani Llewellyn [email protected]

* Add some extra layout definitions for gimp to find some platform executables and shared files
* Update the `environment:` block for runtime search paths that are missing in the platform snap's `desktop-launch` script
* Add missing `libva-drm` and `libva-x11` libraries
* Ensure gimp is built as a relocatable executable so that it can find some of its assets easier in the snap
* Move the debug symbols compiler flags to use the `configure` script's support
* Add missing `iso-codes` because gimp refuses to look for them anywhere but `/usr/share/xml/iso-codes`
* Add missing `lua-lgi` for gimp's lua scripting capability
* Fix the cleanup part to not delete the `iso-codes` we're including in the snap directly

Signed-off-by: Dani Llewellyn <[email protected]>
@lucyllewy lucyllewy requested review from a team, tunix and kenvandine and removed request for a team August 21, 2022 23:14
@merlijn-sebrechts
Copy link
Member

(FYI closed and re-opened pull request because I don't seem to have permissions to rerun tests otherwise)

@kenvandine
Copy link
Contributor

Here's the relevant error from the build failure to avoid others needing to try to view the massive build log.

2023-10-18T20:34:39.5587919Z :: + autoreconf --install
2023-10-18T20:34:39.6364284Z :: autoreconf: error: 'configure.ac' is required
2023-10-18T20:34:39.6376076Z :: error: Failed to run the build script for part 'gimp'.
2023-10-18T20:34:39.8404658Z 'override-build' in part 'gimp' failed with code 1.

@jnsgruk
Copy link
Member

jnsgruk commented Jan 19, 2024

I've taken the changes from here and added them in #255 - closing this for now to avoid a messy merge. Thanks @lucyllewy!

@jnsgruk jnsgruk closed this Jan 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants