Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When the RPC service is encrypted, we should wait for encryption to set up before setting up the managers #1969

Open
joeljfischer opened this issue Apr 12, 2021 · 0 comments
Labels
bug A defect in the library manager-lifecycle Relating to the manager layer - lifecycle manager protocol Relating to the protocol layer

Comments

@joeljfischer
Copy link
Contributor

Bug Report

When connecting to an encrypted system with PutFile encrypted, the library never successfully connects because the PutFile is never sent and the handler is never called. This is because SDLProtocol blocks the sending of any RPCs that are encrypted but encryption is not set up.

We should setup the Lifecycle manager to have a new waiting for encryption setup state between Connected and Registered, or otherwise before SettingUpManagers.

Reproduction Steps
  1. Setup Core to require encryption for PutFile
  2. Setup iOS to connect to Core over encrypted connections
  3. Connect the iOS app to Core
Expected Behavior

The app icon successfully sends

Observed Behavior

The app never finishes connecting and is not usable.

OS & Version Information
  • iOS Version: n/a
  • SDL iOS Version: v7.1-develop
  • Testing Against: Core v7.1-develop
Test Case, Sample Code, and / or Example App

n/a

@joeljfischer joeljfischer added bug A defect in the library manager-lifecycle Relating to the manager layer - lifecycle manager protocol Relating to the protocol layer labels Apr 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A defect in the library manager-lifecycle Relating to the manager layer - lifecycle manager protocol Relating to the protocol layer
Projects
None yet
Development

No branches or pull requests

1 participant