Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Magic Forms does not support October CMS v3 #270

Open
blakej115 opened this issue Sep 27, 2022 · 2 comments
Open

Magic Forms does not support October CMS v3 #270

blakej115 opened this issue Sep 27, 2022 · 2 comments

Comments

@blakej115
Copy link

The following error occurs when trying to submit a form.

Symfony\Component\Mime\Exception\RfcComplianceException: Email "0" does not comply with addr-spec of RFC 2822. in /home/gca.riverworksmarketing.net/public_html/vendor/symfony/mime/Address.php:54

This is because it appears it is now required to provide both a key (email) and value (name) of recipients.

I fixed this by reworking the mail_recipients property into a "dictionary" type, and updated the description text for this property. The description text does still need other translations though.

Here is another error:

"Unknown "spaceless" tag in "/home/gca.riverworksmarketing.net/public_html/themes/gca/partials/contactPrimary/flash.htm" at line 1." on line 160 of /home/gca.riverworksmarketing.net/public_html/vendor/twig/twig/src/Parser.php

It appears the {% spaceless %} tag is no longer supported. I removed this as it appears to not be necessary.

I've attached a pull request that includes these changes: #269

If we could provide the other translations and merge please, that would be great!

Thank you!

@blakej115
Copy link
Author

For anyone looking for it:

There is now an actively maintained fork of this plugin for October CMS v3:
https://octobercms.com/plugin/blakejones-magicforms
https://github.com/blakej115/magic-forms

@nnnext
Copy link

nnnext commented Nov 29, 2022

We use the new Translation function who is coming with october v3.1 and geht the error
Call to undefined method RainLab\Translate\Models\Message::setContext()

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants