diff --git a/.github/workflows/python-ci-single.yml b/.github/workflows/python-ci-single.yml index 408ed20e8e..f07b1da23e 100644 --- a/.github/workflows/python-ci-single.yml +++ b/.github/workflows/python-ci-single.yml @@ -133,14 +133,14 @@ jobs: # Setting PYTHONPATH ensures the tests load the in-tree source code under apis/python/src # instead of the copy we `pip install`ed to site-packages above. That's needed for the code # coverage analysis to work. - run: export SOMA_PY_NEW_SHAPE=false; PYTHONPATH=$(pwd)/apis/python/src python -m pytest --cov=apis/python/src --cov-report=xml apis/python/tests -v --durations=20 --maxfail=50 + run: PYTHONPATH=$(pwd)/apis/python/src python -m pytest --cov=apis/python/src --cov-report=xml apis/python/tests -v --durations=20 --maxfail=50 - name: Run pytests for Python with new shape shell: bash # Setting PYTHONPATH ensures the tests load the in-tree source code under apis/python/src # instead of the copy we `pip install`ed to site-packages above. That's needed for the code # coverage analysis to work. - run: PYTHONPATH=$(pwd)/apis/python/src python -m pytest --cov=apis/python/src --cov-report=xml apis/python/tests -v --durations=20 --maxfail=50 + run: export SOMA_PY_NEW_SHAPE=true; PYTHONPATH=$(pwd)/apis/python/src python -m pytest --cov=apis/python/src --cov-report=xml apis/python/tests -v --durations=20 --maxfail=50 - name: Report coverage to Codecov if: inputs.report_codecov diff --git a/.github/workflows/r-ci.yml b/.github/workflows/r-ci.yml index b5e71f61b8..5a50f47065 100644 --- a/.github/workflows/r-ci.yml +++ b/.github/workflows/r-ci.yml @@ -150,12 +150,12 @@ jobs: - name: Test without new shape if: ${{ matrix.covr == 'no' }} - run: export SOMA_R_NEW_SHAPE=false && cd apis/r/tests && Rscript testthat.R + run: cd apis/r/tests && Rscript testthat.R # https://github.com/single-cell-data/TileDB-SOMA/issues/2407 - name: Test with new shape if: ${{ matrix.covr == 'no' }} - run: cd apis/r/tests && Rscript testthat.R + run: export SOMA_R_NEW_SHAPE=true && cd apis/r/tests && Rscript testthat.R - name: Coverage if: ${{ matrix.os == 'ubuntu-latest' && matrix.covr == 'yes' && github.event_name == 'workflow_dispatch' }} diff --git a/apis/python/src/tiledbsoma/_flags.py b/apis/python/src/tiledbsoma/_flags.py index f0aa8c881b..2ce5a8f0be 100644 --- a/apis/python/src/tiledbsoma/_flags.py +++ b/apis/python/src/tiledbsoma/_flags.py @@ -10,4 +10,4 @@ # removed once https://github.com/single-cell-data/TileDB-SOMA/issues/2407 is # complete. -NEW_SHAPE_FEATURE_FLAG_ENABLED = os.getenv("SOMA_PY_NEW_SHAPE") != "false" +NEW_SHAPE_FEATURE_FLAG_ENABLED = os.getenv("SOMA_PY_NEW_SHAPE") is not None diff --git a/apis/r/R/Init.R b/apis/r/R/Init.R index 8735e8fa20..7c258fc864 100644 --- a/apis/r/R/Init.R +++ b/apis/r/R/Init.R @@ -22,10 +22,10 @@ # This is temporary for https://github.com/single-cell-data/TileDB-SOMA/issues/2407 # It will be removed once 2407 is complete. - if (Sys.getenv("SOMA_R_NEW_SHAPE") == "false") { - .pkgenv[["use_current_domain_transitional_internal_only"]] <- FALSE - } else { + if (Sys.getenv("SOMA_R_NEW_SHAPE") != "") { .pkgenv[["use_current_domain_transitional_internal_only"]] <- TRUE + } else { + .pkgenv[["use_current_domain_transitional_internal_only"]] <- FALSE } }