Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can the diff preview be a vertical diff split. #35

Open
jordwalke opened this issue Apr 30, 2016 · 9 comments
Open

Can the diff preview be a vertical diff split. #35

jordwalke opened this issue Apr 30, 2016 · 9 comments
Labels

Comments

@jordwalke
Copy link

I very much appreciate Vim's vertical diff split. Is it possible to have the undo/redo preview window be split into two and shown using vertical diffsplit?

@jordwalke
Copy link
Author

Sorry for the ping. Does anyone know the answer?

@simnalamburt
Copy link
Owner

simnalamburt commented Jan 29, 2017

@jordwalke Hi Jordan, I'm sorry for the extremely late reply. Your ping was totally adequate so please don't be sorry 👍

Current implementation of vim-mundo has some functionality to render patch diff in vertical diffsplit way, but it's somewhat undocumented and hard to find the way how to do it. Let me tell you how to do it.

At this screen, select a patch that you want to see the patch vertically.

2017-01-29 3 37 26

Then press d.

2017-01-29 3 38 22

Voila! I hope it was what you wanted. Please request some new feature if it is not enough for your use cases. Thanks!

@jordwalke
Copy link
Author

I was thinking of something like this, if you set a "g:mundo_vert_diff" option:

mock

@simnalamburt
Copy link
Owner

That's what we cannot do with current vim-mundo, but it looks useful and ergonomic! I want that feature too.

Personally, I do not have much spare time to implement that feature. But if you or someone else make a PR with that function, I'll document it and merge it. If you're going to implement that feature on your own, call me if you want any help.

@jordwalke
Copy link
Author

Thanks for offering to help, I don't know much about Vim unfortunately, and I'm not even sure if it's possible to have deeply nested diff panes like that.

@dsummersl
Copy link
Collaborator

I like the general idea as well - personally I think its the kind of thing that warrants a new tab (everything on the left side of your beautiful mockup in a new tab). Kinda like what gitv does. I've thought about this a little bit, and I think it warrants a new plugin. That's just me.

@jordwalke
Copy link
Author

A new plugin? But it's so close to the current one that so much of the implementation code would be shared.

@dsummersl
Copy link
Collaborator

It is true, it could be added to this project. I liken it in my head to the use case for vim-fugitive (performing git operations on the current state of a git project) versus gitv (making broadly more historical searches of the git histories). The distinction is fuzzy, as there is overlap.

In either case, code can be shared (the new project could depend on this one, or vice versa).

But maybe this is just me dreading adding the new options changes to this code-base.

@jordwalke
Copy link
Author

Would anyone not want the side by side diff version that I've photoshopped?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants