Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UART entered keys not getting to editor, nor are control-X or -Q anywhere in Tulip from UART #317

Open
bwhitman opened this issue Aug 18, 2024 · 2 comments
Labels
tulipcc Tulip CC hardware

Comments

@bwhitman
Copy link
Collaborator

Discord user reports these aren't working properly (control-X)

@bwhitman bwhitman added the tulipcc Tulip CC hardware label Aug 18, 2024
@bwhitman
Copy link
Collaborator Author

Yes, an issue here. Over UART, keys to the editor keyboard_callback are going to the REPL, overwriting the editor screen, not into the editor itself. Keys over USB are going to the editor.

@bwhitman
Copy link
Collaborator Author

bwhitman commented Aug 20, 2024

Not a fix, but one thing is the idf.py monitor, at least on macOS terminal, will not pass Tulip a UART control-X or control-Q until you do stty -ixon -ixoff before running it. Our actual fix involves the micropython uart ringbuf not passing on characters to the send_keys_to_micropython flow.

i'm not sure what to do about control-Tab, which on my system swaps tabs on the terminal. Maybe we can have a backup key combo for UART users.

@bwhitman bwhitman changed the title Look at editor key callbacks over UART UART entered keys not getting to editor, nor are control-X or -Q anywhere in Tulip from UART Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tulipcc Tulip CC hardware
Projects
None yet
Development

No branches or pull requests

1 participant