Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add results to custom task support #25

Open
SaschaSchwarze0 opened this issue Feb 6, 2023 · 2 comments
Open

Add results to custom task support #25

SaschaSchwarze0 opened this issue Feb 6, 2023 · 2 comments
Assignees
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.

Comments

@SaschaSchwarze0
Copy link
Member

SaschaSchwarze0 commented Feb 6, 2023

When a Shipwright Build runs as part of a larger pipeline, then this pipeline may want to perform further steps after the BuildRun succeeded. For this, it needs access to image details, in particular the digest. We should pass it (maybe together with other image details) as result of the custom task to the pipeline.

Tekton docs: https://tekton.dev/docs/pipelines/customruns/#monitoring-results

@SaschaSchwarze0
Copy link
Member Author

SaschaSchwarze0 commented Feb 13, 2023

Idea: have four results for the output image and users can pick what they need:

  • image: registry.com/namespace/image:v1.1@sha256:...
  • image-name: registry.com/namespace/image
  • image-tag: v1.1
  • image-digest: sha256:...

Name and tag would be used from Build(Run) spec output with tag defaulting to latest. The image-digest would be taken from status output, and would only be set if shipwright pushed the image, or if the build strategy did set the shp-image-digest result.

Based on future Build features, we can extend this with more results such as image-vulnerable.

We can also think about adding source-related results.

@qu1queee qu1queee added good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Apr 19, 2023
@liangyuanpeng
Copy link

I'm make a demo of gitops with shipwright and argocd.

In my case, i need this result to update image tag to git repo.

Once I figure out what's going on here I'll work for it.

Pending for #44

/assign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
Projects
None yet
Development

No branches or pull requests

3 participants