Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

October 11, 2021 Community Meeting #33

Closed
adambkaplan opened this issue Oct 5, 2021 · 9 comments
Closed

October 11, 2021 Community Meeting #33

adambkaplan opened this issue Oct 5, 2021 · 9 comments

Comments

@adambkaplan
Copy link
Member

  • Please add a topic in this thread and add a link to the Github issue associated with the topic.
  • Please make sure you give folks enough time to review/discuss the topic offline on Github before coming into the meeting
  • (optional) Paste the image of an animal 😸
@adambkaplan
Copy link
Member Author

adambkaplan commented Oct 5, 2021

Nomination: @shahulsonhal to shipwright-io/build reviewers list (and join the organization!).

image

@gabemontero
Copy link
Member

gabemontero commented Oct 7, 2021

We have a "new" user beginning to report issues / citing difficulties:

FYI, he is a member of the larger "devtools" team here at RH that the other RH regular community members are a part of

Disclaimer: I'll be on PTO Oct 11 and will miss this discussion, but wanted to raise awareness in case the github notifications for these get lost in the shuffle, and/or nobody gets cycles to look at it before the Oct 11 call.

boo-boo

@SaschaSchwarze0
Copy link
Member

Looking for an owner with a red hat for SHIP-0024: Surfacing Errors to BuildRuns #30.

              .,;>>%%%%%>>;,.                                              
           .>%%%%%%%%%%%%%%%%%%%%>,.                                       
         .>%%%%%%%%%%%%%%%%%%>>,%%%%%%;,.                                  
       .>>>>%%%%%%%%%%%%%>>,%%%%%%%%%%%%,>>%%,.                            
     .>>%>>>>%%%%%%%%%>>,%%%%%%%%%%%%%%%%%,>>%%%%%,.                       
   .>>%%%%%>>%%%%>>,%%>>%%%%%%%%%%%%%%%%%%%%,>>%%%%%%%,                    
  .>>%%%%%%%%%%>>,%%%%%%>>%%%%%%%%%%%%%%%%%%,>>%%%%%%%%%%.                 
 .>>%%%%%%%%%%>>,>>>>%%%%%%%%%%'..`%%%%%%%%,;>>%%%%%%%%%>%%.               
.>>%%%>>>%%%%%>,%%%%%%%%%%%%%%.%%%,`%%%%%%,;>>%%%%%%%%>>>%%%%.             
>>%%>%>>>%>%%%>,%%%%%>>%%%%%%%%%%%%%`%%%%%%,>%%%%%%%>>>>%%%%%%%.           
>>%>>>%%>>>%%%%>,%>>>%%%%%%%%%%%%%%%%`%%%%%%%%%%%%%%%%%%%%%%%%%%.          
>>%%%%%%%%%%%%%%,>%%%%%%%%%%%%%%%%%%%'%%%,>>%%%%%%%%%%%%%%%%%%%%%.         
>>%%%%%%%%%%%%%%%,>%%%>>>%%%%%%%%%%%%%%%,>>%%%%%%%%>>>>%%%%%%%%%%%.        
>>%%%%%%%%;%;%;%%;,%>>>>%%%%%%%%%%%%%%%,>>>%%%%%%>>;";>>%%%%%%%%%%%%.      
`>%%%%%%%%%;%;;;%;%,>%%%%%%%%%>>%%%%%%%%,>>>%%%%%%%%%%%%%%%%%%%%%%%%%%.    
 >>%%%%%%%%%,;;;;;%%>,%%%%%%%%>>>>%%%%%%%%,>>%%%%%%%%%%%%%%%%%%%%%%%%%%%.  
 `>>%%%%%%%%%,%;;;;%%%>,%%%%%%%%>>>>%%%%%%%%,>%%%%%%'%%%%%%%%%%%%%%%%%%%>>.
  `>>%%%%%%%%%%>,;;%%%%%>>,%%%%%%%%>>%%%%%%';;;>%%%%%,`%%%%%%%%%%%%%%%>>%%>.
   >>>%%%%%%%%%%>> %%%%%%%%>>,%%%%>>>%%%%%';;;;;;>>,%%%,`%     `;>%%%%%%>>%%
   `>>%%%%%%%%%%>> %%%%%%%%%>>>>>>>>;;;;'.;;;;;>>%%'  `%%'          ;>%%%%%>
    >>%%%%%%%%%>>; %%%%%%%%>>;;;;;;''    ;;;;;>>%%%                   ;>%%%%
    `>>%%%%%%%>>>, %%%%%%%%%>>;;'        ;;;;>>%%%'                    ;>%%%
     >>%%%%%%>>>':.%%%%%%%%%%>>;        .;;;>>%%%%                    ;>%%%'
     `>>%%%%%>>> ::`%%%%%%%%%%>>;.      ;;;>>%%%%'                   ;>%%%' 
      `>>%%%%>>> `:::`%%%%%%%%%%>;.     ;;>>%%%%%                   ;>%%'  
       `>>%%%%>>, `::::`%%%%%%%%%%>,   .;>>%%%%%'                   ;>%'   
        `>>%%%%>>, `:::::`%%%%%%%%%>>. ;;>%%%%%%                    ;>%,   
         `>>%%%%>>, :::::::`>>>%%%%>>> ;;>%%%%%'                     ;>%,  
          `>>%%%%>>,::::::,>>>>>>>>>>' ;;>%%%%%                       ;%%, 
            >>%%%%>>,:::,%%>>>>>>>>'   ;>%%%%%.                        ;%% 
             >>%%%%>>``%%%%%>>>>>'     `>%%%%%%.                           
             >>%%%%>> `@@a%%%%%%'     .%%%%%%%%%.                          
             `a@@a%@'    `%a@@'       `a@@a%a@@a'

@SaschaSchwarze0
Copy link
Member

Reminder: consider making your community membership public: https://github.com/orgs/shipwright-io/people

      /`·.¸
     /¸...¸`:·
 ¸.·´  ¸   `·.¸.·´)
: © ):´;      ¸  {
 `·.¸ `·  ¸.·´\`·¸)
     `\\´´\¸.·´

@SaschaSchwarze0
Copy link
Member

v0.6.0 sync, remaining TODOs:

                (`.              
                 \ `.           
                  )  `._..---._
\`.       __...---`         o  )
 \ `._,--'           ,    ___,'
  ) ,-._          \  )   _,-' 
 /,'    ``--.._____\/--''  

@SaschaSchwarze0
Copy link
Member

SaschaSchwarze0 commented Oct 11, 2021

We noticed a short-coming of the Buildpacks build strategy: as we bypass pack, the environment variables are not working. They are expected to be stored in files under /platform/env. @shahulsonhal currently develops some code that copies environment variables to as directory. Beside the container environment variables, we also plan to support an optional .env(rc) file. I think it makes sense to offer this feature as open source as well and make use of it in our Buildpacks sample strategies (and suggest it for the upstream Tekton catalog) - it makes the environment variables story complete for Buildpacks.

The strategy then looks like this:

kind: ClusterBuildStrategy
metadata:
  name: buildpacks-v3
spec:
  buildSteps:
    - name: prepare-platform-env
      image: somerepo, maybe quay.io/shipwright/prepare-platform-env
      command:
        - /ko-app/prepare-platform-env
      args:
        - --env-rc=$(params.shp-source-context)
        - --target=/platform/env
        - --blacklist=KUBERNETES*
      volumeMounts:
       - mountPath: /platform/env
         name: platform-env
    - name: build-and-push
      image: docker.io/paketobuildpacks/builder:full
      [...]
      volumeMounts:
       - mountPath: /platform/env
         name: platform-env

Side note for those who are unaware: our controller automatically adds an emptyDir volume to the TaskRun for each volumeMount's unique name that it finds.

Question:

Do we want to provide images that enhance specific sample build strategies as part of Shipwright Build ? Or should we maintain a separate repo for this ?

 ___            ___
/   \          /   \
\_   \        /  __/
 _\   \      /  /__
 \___  \____/   __/
     \_       _/
       | @ @  \_
       |
     _/     /\
    /o)  (o/\ \_
    \_____/ /
      \____/

@SaschaSchwarze0
Copy link
Member

SaschaSchwarze0 commented Oct 11, 2021

  • Let's make @shahulsonhal a reviewer ! PR is in the build repo.
  • In general a good practice to look at issues from time to time to see if some user asks for some help that is easy to give. Beside that we conclude that we will look in detail at grooming
  • Matthias: add a slack message to our channel when a new issue is opened ? Con: clutters the channel. Pro: one does not miss things. Jason: worth a shot and revisit in a month. Adam: don't know how to achieve it. Let's ask in #slack-admin channel. Sascha will quickly do this after the meeting. Edit: see https://kubernetes.slack.com/archives/C4M06S5HS/p1633960687039200
  • Corey and Adam are going to look at the errors ship.
  • v0.6.0 release work:
  • Regarding Buildpacks environment variables. In the latest version in Tekton, it is there: https://github.com/tektoncd/catalog/blob/main/task/buildpacks/0.3/buildpacks.yaml, writes env vars to /platform/env. For shipwright we would do something similar, just not take from a param but from the "real" environment. Still worth checking their opinion on envrc support.

@gabemontero
Copy link
Member

/close

@openshift-ci
Copy link

openshift-ci bot commented Oct 25, 2021

@gabemontero: Closing this issue.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot closed this as completed Oct 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants