Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Use Ginkgo Labels to Isolate Features in e2e Tests #1451

Open
1 task done
adambkaplan opened this issue Dec 18, 2023 · 3 comments
Open
1 task done

[FEATURE] Use Ginkgo Labels to Isolate Features in e2e Tests #1451

adambkaplan opened this issue Dec 18, 2023 · 3 comments
Assignees
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature.

Comments

@adambkaplan
Copy link
Member

adambkaplan commented Dec 18, 2023

Is there an existing feature request for this?

  • I have searched the existing feature requests

Is your feature request related to a problem or use-case? Please describe.

The current e2e test suite for shipwright/build contains tests for multiple features, however it can only be run as an "all or nothing" approach. We should be able to annotate/label tests to identify the associated feature and run subsets of e2e tests.

Use case: Downstream distributions may not support all the features in the "upstream". The build repo also tests the samples, which are not guaranteed to work on all Kubernetes distributions (OpenShift in particular has skews around security that can make these tests require additional setup).

Describe the solution that you would like.

Ginkgo v2 has "primary" support for labels in spec descriptors [1]. These can be used to narrow tests. We can use labels like [FEATURE: xxx] to narrow features, and others like [CORE] to identify specs that test the most core/stable features.

[1] https://onsi.github.io/ginkgo/#spec-labels

Describe alternatives you have considered.

We could leave descriptions in place and add description-based filtering [1].

[1] https://onsi.github.io/ginkgo/#description-based-filtering

Anything else?

The ginkgo docs recommend using the ginkgo cli to run tests and pass in the right flags to do this kind of filtering.

We might be able to keep the existing go test -based approach by passing in flags via -ginkgo.nnn [1]

[1] onsi/ginkgo#381

@adambkaplan adambkaplan added the kind/feature Categorizes issue or PR as related to a new feature. label Dec 18, 2023
@qu1queee
Copy link
Contributor

From Refinement, @adambkaplan to move this to a Community session, for a group discussion.

@adambkaplan adambkaplan added this to the release-v0.13.0 milestone Apr 10, 2024
@qu1queee qu1queee added the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label May 16, 2024
@qu1queee
Copy link
Contributor

qu1queee commented May 16, 2024

From Refinement, this might be a good-second-issue!

@qu1queee qu1queee added the good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. label May 23, 2024
@ayushsatyam146
Copy link

/assign @ayushsatyam146

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature.
Projects
Status: No status
Development

No branches or pull requests

4 participants