Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If a network is disabled in account management on MM but then used in a trade, address populates and re-adds the network #8105

Open
2 tasks done
MBMaria opened this issue Nov 8, 2024 · 1 comment
Labels
bug Something isn't working needs engineering Requires engineering input before bounty

Comments

@MBMaria
Copy link

MBMaria commented Nov 8, 2024

Overview

If you disable say BTC in MM then go to the trade modal and enter an eth to btc trade, to start with, the wallet address will say not connected, but shortly afterwards will populate and re-add BTC as an available network. Same as with eth as shown in jam below

References and additional details

https://jam.dev/c/45e9cfa9-ba99-40fa-aca3-91230ce74c8f

Acceptance Criteria

Should not automatically add a network without being prompted

Need By Date

No response

Screenshots/Mockups

No response

Ownership

  • If my bounty needs engineering or needs product I have added the respective labels on the right
  • As the sponsor of this bounty I will review the changes in a preview environment (ops/product) or review the PR (engineering)

Estimated effort

No response

Sponsor / Stakeholder

No response

Bounty Hunters

  • Join our discord
  • Include an expected timeline for you to complete work in the work plan when you apply for this bounty!
  • Please refer to this link for some basic info
  • Please do not start work on this issue until you are approved in Gitcoin.
@MBMaria MBMaria added bug Something isn't working needs engineering Requires engineering input before bounty labels Nov 8, 2024
@purelycrickets
Copy link

purelycrickets commented Nov 10, 2024

Slightly different but same behavior, when I selected fox in the trade to asset section, my eth address is added: https://jam.dev/c/19fe7ceb-897c-4911-a33a-060e6a78749d

@0xean 0xean moved this from Backlog to Up next / groomed in ShapeShift Dashboard Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs engineering Requires engineering input before bounty
Projects
Status: Up next / groomed
Development

No branches or pull requests

2 participants