Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show current playback rate and quality without hover #7444

Open
kommunarr opened this issue Oct 19, 2024 · 6 comments
Open

Show current playback rate and quality without hover #7444

kommunarr opened this issue Oct 19, 2024 · 6 comments
Labels
component: UI The issue involves the Shaka Player UI flag: seeking PR We are actively seeking PRs for this; we do not currently expect the core team will resolve this type: enhancement New feature or request
Milestone

Comments

@kommunarr
Copy link

Is your feature request related to a problem? Please describe.
The playback rate and quality are currently not visible without hover or focus when they are entries in the button panel. This can be inconvenient when I want to know the current playback rate or quality by visual scanning alone.

Describe the solution you'd like
Have the playback rate and quality visible in their corresponding button panel entries above, below, or inside their icons.

Describe alternatives you've considered
None that come to mind.

Are you planning send a PR to add it?
No, not at this time.

@kommunarr kommunarr added the type: enhancement New feature or request label Oct 19, 2024
@shaka-bot shaka-bot added this to the Backlog milestone Oct 19, 2024
@avelad avelad added the component: UI The issue involves the Shaka Player UI label Oct 21, 2024
@avelad
Copy link
Member

avelad commented Oct 22, 2024

I'm going to leave the issue open for a week to see if anyone else is interested in this. Thanks!

@avelad avelad added the status: waiting on response Waiting on a response from the reporter(s) of the issue label Oct 22, 2024
@shaka-bot
Copy link
Collaborator

Closing due to inactivity. If this is still an issue for you or if you have further questions, the OP can ask shaka-bot to reopen it by including @shaka-bot reopen in a comment.

@shaka-bot shaka-bot removed the status: waiting on response Waiting on a response from the reporter(s) of the issue label Oct 29, 2024
@kommunarr
Copy link
Author

@shaka-bot reopen

To clarify, not sure if we're waiting for more consensus on the idea or a developer. I would certainly be open to adding it in the next two months if the latter.

@shaka-bot shaka-bot reopened this Oct 29, 2024
@avelad
Copy link
Member

avelad commented Oct 29, 2024

Ok, I'll leave it open for a few months in case anyone wants to work on it.

@avelad avelad added the flag: seeking PR We are actively seeking PRs for this; we do not currently expect the core team will resolve this label Oct 29, 2024
@m3thm4th
Copy link

Thank you @kommunarr, this feature is much needed

@joeyparrish
Copy link
Member

I think a UI plugin would be pretty reasonable. The APIs to get this information are stable, and so is the UI plugin interface. If the app wants a custom UI element for this, that shouldn't be an issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: UI The issue involves the Shaka Player UI flag: seeking PR We are actively seeking PRs for this; we do not currently expect the core team will resolve this type: enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants