-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Player not run smoothly when gaps detected #7138
Comments
Thank you for filing. I see in #7130 (comment) that you're having this issue in production, and it seems from the two issues that both 4.10.6 and 4.10.9 both have this issue. The first thing I would recommend is trying older revisions (4.10.5, 4.10.4, ...) until you find one that does not have this issue. There are several advantages of this:
Let us know how this goes! |
Thanks @joeyparrish, we have just have to restart our CDN to temporarily fix this, in the next few days this issue will happen again. After discussion this morning, we will wait for your fix for gap-jumping. It would be grateful if you can let me know your plan when this will be fixed. Thank you. |
You should really do that testing in a staging environment. Nobody expects (or recommends) that you test an old version or a new version in production. That is definitely not safe. But testing in a staging environment is something you should really invest in, for the health of your business. We (at Google) don't have a timeline for a fix, and this is not on my list any time soon. If you can back-test older versions in a non-production environment, it will really help accelerate a fix. |
Hello @joeyparrish I also already tried version 4.0.2, the oldest version when we started using shaka and the issue of gap-jumping is still happen. |
Hello @joeyparrish , the gap-jumping happen again with this stream, I rolled back to version shaka 3.3.19 to check gap-jumping but player throws error 4032. Can you please take a quick check for error 4032 here? I not happen when I use version shaka 4.5.x or higher |
In email, I helped @vanminhquangtri work through 3.3.19 issues (missing mux.js). They determined that 3.3.19 works, but 4.0.0 does not. So that is the range that needs to be bisected. (Or 3.3.0 to 4.0.0, since 3.3.19 is from a branch.) |
Thanks @joeyparrish , may I know if there will be a fix for this? |
We haven't found the root cause yet, so it's a little hard to say anything about a potential fix. You are more than welcome to help investigate if this is an urgent issue for you. That's part of the beauty of open source. |
Also, I don't understand how a player bug would require you to restart a CDN. Can you elaborate on that? Perhaps there's some key information in that which could be helpful. |
Hello @joeyparrish , |
Ah, I see. So it's not that the player breaks the CDN somehow, but that restarting the CDN/packager changes the stream in a way that no longer triggers the bug in the player. Is that accurate? |
Hello @joeyparrish yes correct. Restart CDN help to prevent gaps happen in stream in a few days. |
Hello @joeyparrish may I know if there's any going for this issue? A few days pass I tried to debug your sourcode but have no luck to find the problem. |
Hello @joeyparrish do you have any update for this issue? |
Hello @avelad may I know if @joeyparrish is not handled this anymore? Thanks |
Since this is specific to your CDN and application, I recommend you try bisecting the source range between the last working version and the first non-working version: 3.3.0 to 4.0.0. Here are the general docs for You want to do something like this: git bisect start
git bisect bad v4.0.0
git bisect good v3.3.0 Then follow the prompts. At each revision, compile the player, test it in your app, then report back to git bisect with either If you can identify the player change responsible for the playback issue, we could help you understand the behavior and suggest a fix for you to test. |
Have you read the FAQ and checked for duplicate open issues?
Yes
If the problem is related to FairPlay, have you read the tutorial?
Yes
What version of Shaka Player are you using?
4.10.9 shaka UI
https://cdnjs.cloudflare.com/ajax/libs/shaka-player/4.10.6/shaka-player.ui.min.js
Can you reproduce the issue with our latest release version?
Yes
https://codesandbox.io/s/runtime-framework-8rvth7
https://shaka-player-demo.appspot.com/demo/#audiolang=en;textlang=en;uilang=en;asset=https://vips-livecdn.fptplay.net/MTA4NDUxNDB8Y25iY19obHMuc21pbHxmcHR8MTcyMjk5NDY5OXwxMDAuOTEuMTI1LjgxfDExNjMxZTdlMTM5MjQxYTFmMTc2ODE5ODJlOTFhYTYx/fnxhd2/cnbc_hls.smil/playlist.m3u8;panel=CUSTOM%20CONTENT;build=uncompiled
Can you reproduce the issue with the latest code from
main
?Yes
https://codesandbox.io/s/runtime-framework-8rvth7
https://shaka-player-demo.appspot.com/demo/#audiolang=en;textlang=en;uilang=en;asset=https://vips-livecdn.fptplay.net/MTA4NDUxNDB8Y25iY19obHMuc21pbHxmcHR8MTcyMjk5NDY5OXwxMDAuOTEuMTI1LjgxfDExNjMxZTdlMTM5MjQxYTFmMTc2ODE5ODJlOTFhYTYx/fnxhd2/cnbc_hls.smil/playlist.m3u8;panel=CUSTOM%20CONTENT;build=uncompiled
Are you using the demo app or your own custom app?
Both.
This is demo codesandbox
https://codesandbox.io/s/runtime-framework-8rvth7
https://shaka-player-demo.appspot.com/demo/#audiolang=en;textlang=en;uilang=en;asset=https://vips-livecdn.fptplay.net/MTA4NDUxNDB8Y25iY19obHMuc21pbHxmcHR8MTcyMjk5NDY5OXwxMDAuOTEuMTI1LjgxfDExNjMxZTdlMTM5MjQxYTFmMTc2ODE5ODJlOTFhYTYx/fnxhd2/cnbc_hls.smil/playlist.m3u8;panel=CUSTOM%20CONTENT;build=uncompiled
If custom app, can you reproduce the issue using our demo app?
https://codesandbox.io/s/runtime-framework-8rvth7
https://shaka-player-demo.appspot.com/demo/#audiolang=en;textlang=en;uilang=en;asset=https://vips-livecdn.fptplay.net/MTA4NDUxNDB8Y25iY19obHMuc21pbHxmcHR8MTcyMjk5NDY5OXwxMDAuOTEuMTI1LjgxfDExNjMxZTdlMTM5MjQxYTFmMTc2ODE5ODJlOTFhYTYx/fnxhd2/cnbc_hls.smil/playlist.m3u8;panel=CUSTOM%20CONTENT;build=uncompiled
What browser and OS are you using?
Both window 11 Pro and macOS
For embedded devices (smart TVs, etc.), what model and firmware version are you using?
I not use embedded devices
What are the manifest and license server URIs?
Manifest:
https://vips-livecdn.fptplay.net/MTA4NDUxNDB8Y25iY19obHMuc21pbHxmcHR8MTcyMjk5NDY5OXwxMDAuOTEuMTI1LjgxfDExNjMxZTdlMTM5MjQxYTFmMTc2ODE5ODJlOTFhYTYx/fnxhd2/cnbc_hls.smil/playlist.m3u8
This is non-DRM
What configuration are you using? What is the output of
player.getConfiguration()
?Please refer to the attached config.txt, it's long so can not paste here
config.txt
What did you do?
Init player as normal
What did you expect to happen?
Player run smoothly despite of gap
What actually happened?
Please periodically paused for a while then continue. This is because of streaming gap. I think there's would be some configuration but I can not find it.
BUT, with other player, like videojs, bitmovin, this not happen. Playback seem very smoothly, there's no pause
Videojs demo:
https://codesandbox.io/s/serene-cannon-rrr63f?file=/index.html
Bitmovin demo:
https://bitmovin.com/demos/stream-test/?format=hls&manifest=https%3A%2F%2Fvips-livecdn.fptplay.net%2FMTA4NDUxNDB8Y25iY19obHMuc21pbHxmcHR8MTcyMjk5NDY5OXwxMDAuOTEuMTI1LjgxfDExNjMxZTdlMTM5MjQxYTFmMTc2ODE5ODJlOTFhYTYx%2Ffnxhd2%2Fcnbc_hls.smil%2Fplaylist.m3u8
I think this is a feature of shaka player when it detect gap it will pause player for a while to wait for the missing content. But this make the watching not smoothly and somehow make it enjoyable for viewer.
Are you planning send a PR to fix it?
Sure, I will do if I can
The text was updated successfully, but these errors were encountered: