feat: migrate from Newtonsoft.Json to System.Text.Json #1209
+9,538
−334
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Closes #1208
Possibly impacts #985 (which is a duplicate of a #1050 which is a request to support
System.Text.Json
)Description
This PR includes conditional compilation checks to use
System.Text.Json
instead ofNewtonsoft.Json
everywhere when targeting .NET Standard 2.0The tests projects have been duplicated and modified to test both the old and the new versions.
All tests pass (except integration tests, which I could not get to work despite having configured a valid SendGrid API Key) - As a consequence of this, all integration tests are marked for skipping using
[Fact(Skip = ...
and[Theory(Skip = ...
Checklist
If you have questions, please file a support ticket, or create a GitHub Issue in this repository.