Skip to content
This repository has been archived by the owner on Mar 5, 2023. It is now read-only.

Integrate test script and test data into the dev guide #732

Open
damithc opened this issue Nov 9, 2017 · 6 comments
Open

Integrate test script and test data into the dev guide #732

damithc opened this issue Nov 9, 2017 · 6 comments

Comments

@damithc
Copy link
Contributor

damithc commented Nov 9, 2017

Currently, we ask students to add a test script and a test data file near the final submission. We can integrate it to the dev guide (e.g. as an appendix), to reduce the number files that need to be submitted. We can also add a command to load data from a file so that there is a legit reason to include a test data file in the code base.

@pyokagan pyokagan added the c.Project Project (may or may not consist of a research component). label Dec 9, 2017
@vivekscl
Copy link
Contributor

As discussed with Prof, It seems like a good idea to take in the file path as a command line argument, if given, and if it's valid, load the test file else load the default file. This is would be preferred over creating an entire command since this function is not intended for users. What do you think @Zhiyuan-Amos @yamidark @Rinder5 ?

@damithc
Copy link
Contributor Author

damithc commented Mar 29, 2018

One limitation of this approach is that it can be used for manual testing only, am I right?

@Rinder5
Copy link
Contributor

Rinder5 commented Mar 29, 2018

would you only be able to load in 1 test file?

@vivekscl
Copy link
Contributor

One limitation of this approach is that it can be used for manual testing only, am I right?

Yup! And it can only be done using the jar file.

would you only be able to load in 1 test file?

That should be the case since the use case is such that during the manual testing process, the student would download the other team's jar file along with the test file and then load it into the application using the command line. So it only happens once during the launch of the application. I believe doing it this way would also result in the file being erased from the application once it closes though.

@Zhiyuan-Amos
Copy link
Contributor

Sounds good!

@yamidark
Copy link
Contributor

Yep sounds good to me too.

@pyokagan pyokagan removed the c.Project Project (may or may not consist of a research component). label Jan 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

6 participants