Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SVG fixes should be moved to svg-renderer's fix-up-svg #1269

Open
fsih opened this issue Oct 8, 2020 · 0 comments · May be fixed by scratchfoundation/scratch-gui#6556
Open

SVG fixes should be moved to svg-renderer's fix-up-svg #1269

fsih opened this issue Oct 8, 2020 · 0 comments · May be fixed by scratchfoundation/scratch-gui#6556
Assignees
@fsih
Labels
tech debt

Comments

@fsih
Copy link
Contributor

fsih commented Oct 8, 2020

Expected Behavior

SVG fixes are performed in svg-renderer, where they are fixed for assets across scratch repos

Actual Behavior

Some fixes are performed only in Paint: https://github.com/LLK/scratch-paint/blob/7dd437415c8dcc921d68627c26af1c6e423f2d70/src/containers/paper-canvas.jsx#L197

Moving the fixes to svg-renderer can help fix security issues
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fsih fsih

Labels
tech debt
Projects
None yet
Milestone
No milestone
2 participants
@BryceLTaylor @fsih