Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Basic benchmark suite #184

Closed
pablohoffman opened this issue Feb 24, 2015 · 4 comments · May be fixed by #185
Closed

Basic benchmark suite #184

pablohoffman opened this issue Feb 24, 2015 · 4 comments · May be fixed by #185
Assignees
@immerrr
Labels
enhancement

Comments

@pablohoffman
Copy link
Contributor

We need basic benchmark suite for Splash, something that renders a few typical web pages, hosted locally (to avoid network latencies affecting the results). Just a few (5-10) diverse enough websites should be enough to get started.

Goals for this benchmark in order of priority:

  1. compare Splash performance reliable on different server configurations/deployments
  2. find out typical render metrics, like average/peak memory consumption. This should help to figure out the optimal SLASH_SLOTS value for different server configurations
  3. compare Splash performance with other tools (see Performance compared to PhantomJS #99)
@pablohoffman
Copy link
Contributor Author

@immerrr could you work on this soon?

@immerrr
Copy link
Contributor

immerrr commented Feb 24, 2015

FTR, this is the benchmark script I used when hacking on splash: https://gist.github.com/immerrr/a1419c4175d9c59d1cb6

@immerrr
Copy link
Contributor

immerrr commented Feb 24, 2015

yup, will do

@immerrr immerrr self-assigned this Feb 24, 2015
@immerrr immerrr mentioned this issue Feb 27, 2015
Open
@immerrr
Copy link
Contributor

immerrr commented Mar 2, 2015

Could you try the code from #185 and see if it is usable?

@pablohoffman pablohoffman closed this as not planned Won't fix, can't repro, duplicate, stale Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@immerrr immerrr

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Benchmark suite scrapinghub/splash
3 participants
@pablohoffman @immerrr @Gallaecio