wget downloaded moonfire-nvr-0.7.16 's cargo test fails

[fr4nz909]

I downloaded the archived package of moonfire-nvr-0.7.16 and ran tests inside /server, they failed with the following error message:

`Compiling libsystemd v0.7.0
Compiling mp4 v0.9.2 (https://github.com/scottlamb/mp4-rust?branch=moonfire#388fb476)
Compiling reffers v0.7.0
Compiling sync_wrapper v0.1.2
error: failed to run custom build command for moonfire-nvr v0.0.0 (/root/rust/moonfire-nvr-0.7.16/server)

Caused by:
process didn't exit successfully: /root/rust/moonfire-nvr-0.7.16/server/target/debug/build/moonfire-nvr-f9a5569a9564ce58/build-script-build (exit status: 101)
--- stdout
cargo:rerun-if-changed=build.rs
cargo:rerun-if-env-changed=VERSION

--- stderr
thread 'main' panicked at build.rs:173:38:
called Option::unwrap() on a None value
note: run with RUST_BACKTRACE=1 environment variable to display a backtrace
warning: build failed, waiting for other jobs to finish...`

Could the reason just be, that there was an older version of moonfire on the system before?

Addition:
Tests do not fail with the master branch code.
Only the archived version has the tests fail.

[scottlamb]

Ahh. The failure is from here:

moonfire-nvr/server/build.rs

Lines 161 to 173 in e6c7b80

	// Get version from `git describe`. Inspired by the `git-version` crate.
	// We don't use that directly because `cross`'s default docker image doesn't install `git`,
	// and thus we need the environment variable pass-through above.
	// Avoid reruns when the output doesn't meaningfully change. I don't think this is quite right:
	// it won't recognize toggling between `-dirty` and not. But it'll do.
	let dir = Command::new("git")
	.arg("rev-parse")
	.arg("--git-dir")
	.output()?
	.stdout;
	let dir = String::from_utf8(dir).unwrap();
	let dir = dir.strip_suffix('\n').unwrap();

It fails because the source bundle from github doesn't include the .git directory, and the error handling when that command fails could use some work.

As a workaround, try VERSION=v0.7.16 cargo test instead.

[scottlamb]

This will give a more helpful message as of 6c227ec