-
Notifications
You must be signed in to change notification settings - Fork 201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unexpected error when testing project with jdk11 #947
Comments
Hey @Tomahna, thanks for reporting! Yeah, unfortunately this bug fell through the crack because we're not testing Java 11 on our Nailgun infrastructure. I'll have a look into it. |
I had the same issue on JDK11, but I noticed that it always works fine if I launch I added I do not know which entry exactly from |
That's great news! I'm honestly not sure why this is happening, whenever we add JDK11 to our testing infrastructure we'll see if this is an issue or not. If this isn't, I'll be closing it and instead tell people to look better into their Java installations. Recommendations on how to improve the workflow of inspecting and setting JAVA_HOME while debugging this is welcome. Note that |
Note that I tested both on my workstation (nixos) and the one of a colleague (manjaro) and we both had the same issue even when launched from the command line with bloop server. |
It seems my path included JDK8, that why it worked. When JDK8 removed, I get the same error consistently. |
Fixing this is a priority for the next release 1.3.3. Will keep you all posted, thanks for the comments and detailed explanations. |
Upstream nailgun ticket about supporting JDK 11, looks like we will need to make changes in our fork to support JDK 11. facebookarchive/nailgun#172 |
After a little bit more investigation, I can confirm this doesn't look like an issue caused by nailgun but by sbt's test interface. My guess is that if we've got this far with JDK 11 is that nailgun is indeed compatible with JDK 11. I will confirm this test by running tests on JDK 11 in our CI. |
I can confirm that it works well with bloop v1.3.2+125-2d6bf327. Thanks @jvican for your hard work. |
@Tomahna curious how can I try |
@Tomahna thanks! |
Hello,
First thank for your efforts, bloop is definitely an awesome tools.
I'm trying to get bloop working with java 11, compilation works fine but on some projects tests fail to run.
System:
nixos on unstable channel
java openjdk 11.0.3-internal 2019-04-16
bloop 1.3.2+2-ac2e07ff
Reproducing it:
I experience this only on java 11, running it on java 8 works fine. Bloop is running as a systemd service. Note that this does not seem to occur on all projects. For example, on cats, bloop test coreJVM runs fine.
The text was updated successfully, but these errors were encountered: