Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[On hold] Impossible dates on calendar when creating an event #6

Open
4 tasks
clue4 opened this issue Sep 25, 2022 · 2 comments
Open
4 tasks

[On hold] Impossible dates on calendar when creating an event #6

clue4 opened this issue Sep 25, 2022 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@clue4
Copy link
Collaborator

clue4 commented Sep 25, 2022

Problem: When creating a new event and choosing the dates, we are able to select impossible dates on the calendar (ex: selecting a start date, then selecting an end date that is before the start date)
Solution: Add validation to ensure that users cannot select impossible dates once they choose a start date

Specs:

  • If a user selects a start date, they should not be able to select an end date before the start date
    • User should be able to select an end date that is the same date as the start date so long as the end time is after the start time
  • If a user changes the start date, allowable end dates should be adjusted accordingly
  • Make sure selecting a blank space doesn't do anything -- see Kaleb's additional information below
@clue4 clue4 added the bug Something isn't working label Sep 25, 2022
@clue4 clue4 moved this to Blocked/More details needed in ScoutTrek Kanban Board Sep 25, 2022
@clue4 clue4 added the question Further information is requested label Sep 28, 2022
@kalebjdavenport
Copy link

For information on the final bullet point, see documentation (here)[https://github.com/wix/react-native-calendars#agenda]. Essentially there are certain actions that can be performed when the user taps outside the date fields. For example, the calendar could be dismissed. Ideally, we want to make sure that the calendar is only rendered for each month and the only action that can be taken is to select a valid date.

@kalebjdavenport
Copy link

I ran into problems with this plugin, so my recommendation would be to add as much validation as you can within reason. If there are edge cases such as scrolling a full month backward and then the dates becoming valid again, do not spend more than half an hour on a solution because it's extremely low priority.

@clue4 clue4 removed the question Further information is requested label Oct 5, 2022
@clue4 clue4 changed the title [Draft issue] Impossible dates on calendar when creating an event Impossible dates on calendar when creating an event Oct 5, 2022
@clue4 clue4 moved this from Blocked/More details needed to Todo in ScoutTrek Kanban Board Oct 5, 2022
@clue4 clue4 moved this from Todo to In Progress in ScoutTrek Kanban Board Oct 16, 2022
@clue4 clue4 moved this from In Progress to Blocked/More details needed in ScoutTrek Kanban Board Oct 28, 2022
@clue4 clue4 changed the title Impossible dates on calendar when creating an event [On hold] Impossible dates on calendar when creating an event Dec 11, 2022
@ross3102 ross3102 removed their assignment Oct 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Blocked/On Hold
Development

No branches or pull requests

4 participants