Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[experiment] Explore user actions #460

Closed
wants to merge 27 commits into from
Closed

[experiment] Explore user actions #460

wants to merge 27 commits into from

Conversation

ro0gr
Copy link
Collaborator

@ro0gr ro0gr commented Oct 6, 2019 •
edited
Loading

Opened this PR to share the status and bootstrap a discussion about a desirable API to define user actions.

Fixes #453

description tbd

@ro0gr ro0gr changed the title [do not merge] Implement action utility [experiment] Explore user actions Oct 29, 2019
@coveralls
Copy link

coveralls commented Oct 29, 2019 •
edited
Loading

Coverage Status

Coverage decreased (-1.3%) to 97.062% when pulling 54d5677 on ro0gr:user-action into f303657 on san650:master.

@ro0gr
Copy link
Collaborator Author

ro0gr commented Oct 29, 2019

just re-written all the built-in actions with a new proposed run+action. It allowed to drastically cleanup execution contexts and (I believe) make actions implementation a bit more straightforward.

with this change all the execution context methods intended to manipulate with DOM elements do only accept an element instead of a combo of selector, container, options.
Which means, a single invocation of MyExecutionContext.click would only interact with a single DOM node.

ro0gr and others added 23 commits November 12, 2019 00:30
@ro0gr
cache execution_context
3ad2fcd
@ro0gr
Make execution context aware of the current action promise
fdf2f0d
@ro0gr
Allow passing of an Error instance to the throwBetterError
46bf062
@ro0gr
[Needs Tests] Implement action utility
7ea4ef1 
+ invokeHelper
@ro0gr
Add negative test case for fillable with clue
d7e660e
@ro0gr
ExecutionContext: fillable
ab0879a
@ro0gr
Restore fillable
0305adc
@ro0gr
ExectuionContext: click
2ca4bab
@ro0gr
fixup! clickOnText
883b570
@ro0gr
ExecutionContext: triggerEvent
2dac5b4
@ro0gr
ExecutionContext: remove assertElementExists
0380e26 
as not needed anymore
@ro0gr
ExecurionContext: focus/blur
22290ba
@ro0gr
move visitable to run
b7194ee
@ro0gr
remove code unused anymore
668b902
@ro0gr
ExecutionContext: Extract find logic
23eb286
@ro0gr
read execution context from chainable
a393966
@ro0gr
maintain execution context only inside run
89282b1
@ro0gr
make sure run passes chained node
9926b18
@ro0gr
fallback to executionContext key
aa8ada4
@ro0gr
add sync invocation errors
bc33875
@ro0gr
imporove tests
b18258f
@ro0gr
Move visitable to action
124a23d
@ro0gr
Make sure a proper context applied before DOM helper
3947a21
@ro0gr
Copy link
Collaborator Author

ro0gr commented May 9, 2020

this led me to #509

@ro0gr ro0gr closed this May 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Custom properties
2 participants
@ro0gr @coveralls