Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Comment]: #13

Open
OWissett opened this issue Jan 24, 2023 · 10 comments
Open

[Comment]: #13

OWissett opened this issue Jan 24, 2023 · 10 comments
Labels
bug Something isn't working

Comments

@OWissett
Copy link

What happened?

This isn't really a bug.

I wanted to drop a comment on your Medium article since you don't state that you need to run:

cargo install grcov

Without running this, you get a cryptic filesystem error. After digging around in the source files, I realised that I need the grcov tool. I suppose this likely is installed when you setup the package from this repo, however, I was adding test coverage to an existing large repo.

What type of Operating System?

Linux

Steps to produce this issue.

...
@OWissett OWissett added the bug Something isn't working label Jan 24, 2023
@OWissett
Copy link
Author

I left this comment here, since I couldn't leave a comment on the article its self.

Might be worth a simple revision, since it is an essential step to get xtaskops working. Also you should probably say how to actually implement that function you give, since you don't use that implementation in this repo, but use xtaskops::tasks::main() to pull in all of the default ops tasks.

@jondot
Copy link
Member

jondot commented Jan 24, 2023

Thanks! do you think adding an install through xtaskops is a good solution?
Or just adding a verbal instruction?

@OWissett
Copy link
Author

I think just verbal instruction

cargo install grcov

Also I think that you need to ensure that you have the coverage tooling installed for rustc:

rustup component add llvm-tools-preview

@OWissett
Copy link
Author

I suppose that having it as a xtask job could be nice for this repo,

so that you can run cargo xtask init which installs all of the dev dependencies for this which aren't necessarily in the Cargo.toml

@OWissett
Copy link
Author

You also need to install cargo-bloat, cargo-hack, and cargo-watch, maybe more too

@jondot
Copy link
Member

jondot commented Jan 24, 2023

interesting, some of it is here: https://github.com/jondot/xtaskops/blob/master/xtaskops/src/tasks.rs#L245

@OWissett
Copy link
Author

Ah cool.

I guess you just need grcov then and the llvm tools.

@jondot
Copy link
Member

jondot commented Jan 24, 2023

perfect, thanks!

@OWissett
Copy link
Author

OWissett commented Jan 24, 2023

PR: jondot/xtaskops#3

@jondot
Copy link
Member

jondot commented Jan 24, 2023

Thanks, just merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants