-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace WindowManagerFlags
with ndk::WindowFlags
#48
Comments
maybe. I'm a little bit in two minds about whether to go in the other direction though and generally keep the ndk crate as an implementation detail that's not exposed in the public API. E.g. in the case of the input API I started out by exposing ndk crate types but that's been particularly problematic considering the differences between The overall surface area for the android-activity crate isn't that big, so I'm not massively concerned about some redundancy, when it also helps decouple the dependency so we e.g. don't have to worry about synchronizing semver changes. That said though - On a case by case basis though if it's clear we can just have an enum / bitfield type in one place with docs, and it can be autogenerated and also account for maintaining backwards compatibility (e.g. with |
the question of exposing the ndk crate API is also relevant here: #45 |
I feel like the |
https://docs.rs/ndk/0.7.0/ndk/native_activity/struct.WindowFlags.html
The
ndk
crate provides the same bitflag enum based on generated rather than hardcoded constants, albeit without documentation. Shouldandroid-activity
just use that (after helping thendk
take over the docs)?The text was updated successfully, but these errors were encountered: